Conversation
- Added 'wait_for_receipt' option (bool, default True) to control whether to wait for transaction receipt - Added 'timeout' option (int/float) to specify custom timeout for waiting for receipt - Maintains backward compatibility by defaulting wait_for_receipt to True - Added comprehensive unit tests (10 new tests) and integration tests (5 new tests) - Fixed import issue in test_derivative_data.py (using pytest.raises instead of _pytest.raises)
sebsadface
requested review from
AndyBoWu,
bonnie57,
edisonz0718,
limengformal and
lucas2brh
as code owners
bonnie57
reviewed
Aug 18, 2025
bonnie57
reviewed
Aug 18, 2025
bonnie57
reviewed
Aug 18, 2025
lucas2brh
approved these changes
Aug 18, 2025
bonnie57
reviewed
Aug 18, 2025
bonnie57
reviewed
Aug 18, 2025
lucas2brh
deleted the
seb/allow-custom-time-out-and-opt-wait-for-receipt
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wait_for_receiptoption (bool, default True) to control whether to wait for transaction receipttimeoutoption (int/float) to specify custom timeout for waiting for receiptwait_for_receiptto Truetest_derivative_data.py(usingpytest.raisesinstead of_pytest.raises)Test Plan
Added additional unit and integration tests, all test passes.
