Conversation
…lass and updating IPAsset methods to utilize it for improved type safety and clarity
…n __all__ exports for improved module structure
bonnie57
requested review from
AndyBoWu,
edisonz0718,
limengformal,
lucas2brh and
sebsadface
as code owners
…rmission handling to use AccessPermission.ABSTAIN; enhance test cases to utilize DerivativeDataInput for improved clarity and type safety
bonnie57
changed the title
…n DerivativeData for improved clarity and consistency
lucas2brh
approved these changes
Aug 12, 2025
|
|
||
| return { | ||
| "signature": signed_message.signature.hex(), | ||
| "signature": "0x" + signed_message.signature.hex(), |
Collaborator
There was a problem hiding this comment.
Is this the change we discussed earlier—the return value default without the 0x? If so, we should emphasize it.
Contributor
Author
There was a problem hiding this comment.
It's a generated signature instead of tx_hash.
lucas2brh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
register_derivativemethodAccessPermissionenum and apply it to the related methods and signatureDerivativeDataInputtype and thederivative_datadata class to validate logicget_function_signaturemethod to get the function signaturetests/unit/conftest.pyfile to save common fixturesTest Plan
Unit test
Integration test
Related Issue
#97