Conversation
…me, need to figure out how to pass arguments to ESBUILD to deal with importing the "global" object in the existing code.
|
This PR has some issues but I'm submitting hoping I can get some help. The code to register the addon makes use of the The problem is the bundler is not finding it in the local dependencies so it fails to run or build Storybook. The bundler in use for those two steps seems to be ESBUILD, not Webpack. Attempting to deal with this problem using standard Storybook's Webpack configuration made no difference. I'm attaching the error below. Is it possible to pass arguments to ESBUILD via the Storybook CLI? Or am I approaching this the wrong way? |
|
@fgaleano, thanks for putting this pull request together and having it support Storybook 7.0. We're extremely thankful for it 🙏 ! I will reach out to the Storybook team and see how they can unblock you on getting this one merged and released. It goes without saying this could take some time as the team is getting geared up for the upcoming Storybook release and probably won't be able to commit too much time. Sorry for the inconvenience on this. I hope you understand. Hope you have a great weekend. Stay safe cc @shilman, @ndelangen , @yannbf |
|
@vanessayuenn do we put this on the 7.0 burndown chart somewhere? |
|
We had a meeting with the team and decided the best way forwards for this storybook team would be to push this out of the storybook organization. @fgaleano as @jonniebigodes already mentioned we're very glad with the assistance here; but no-one on the storybook team uses this addon, plus it's usage is waning, thus we decided to focus our efforts/time/energy elsewhere. I'll spend a little time trying to solve the issue above, but we won't be making a new release of this package. We'll be happy to redirect users to the fork in the README, afterwards. |
|
I tried pulling your branch, but it's not using TSup/Esbuild at all... |
|
@ndelangen Thanks for the update. I'll be on the lookout for the deprecation announcement. I may or may not use my fork to publish the independent version. Out of curiosity, what is the Storybook team using for analytics? Or is analytics not really an area of focus? As for the issue I reported, if you try to run or build Storybook from the branch, you should get the same error I shared above. The stack trace says its coming from ESBuild. Doesn't Storybook use ESBuilt internally? If you're not getting the error, let me know. Thanks. |
|
@fgaleano I understand the confusion now. I ran https://github.com/storybookjs/addon-kit (the template of this repo) has been updated to use TSup + ESbuild.
We don't track any events in the browser for any storybook we own. |
|
Hi @fgaleano! Hope you've been well! Since Norbert's last message, we've set up a community group for collective addon maintenance: https://github.com/storybook-community. I think this addon would be a great addition to the community addon list, and I'm curious if you'd like to join and help us maintain it? We could help with putting it back in shape for Storybook 9, and I'd love to have someone like you who knows Google Analytics well enough to maintain the core logic inside the addon. Let me know what you think and feel free to reach out on Discord as well. |
4 participants
Closes storybookjs/storybook#20366
Updating dependencies to test support for Storybook v7.