Audit and clean up CI pipeline verification path#108
Conversation
- Update golangci-lint from pinned v1.57.0 to @latest - Move storj-up install from Jenkinsfile to Makefile integration-image-build - Remove Splunk tests (subset of Ceph tests) from Makefile and Jenkinsfile - Add integration-ceph-tests to integration-all-tests (was missing) - Improve integration-env-clean for zero-leftover policy: - Run docker compose down first with --volumes --remove-orphans - Add cleanup for ci, python, golang Docker images - Update README to reflect splunk removal Co-authored-by: amwolff <30234756+amwolff@users.noreply.github.com>
amwolff
left a comment
There was a problem hiding this comment.
Did you make sure that make verify starts up properly, passes, and tears down cleanly after your changes?
…i, restore storj-up in Jenkinsfile, add storj-up to install-dev-dependencies Co-authored-by: amwolff <30234756+amwolff@users.noreply.github.com>
|
@copilot you're supposed to run everything as if you were developing; |
- Replace deprecated --print-resources-usage with --verbose (golangci-lint v2) - Remove stale cURL reference from install-dev-dependencies comment - Fix integration-env-logs: replace stale integration-sim container with docker compose logs - Fix integration-ceph-tests help text for consistency with other targets Co-authored-by: amwolff <30234756+amwolff@users.noreply.github.com>
Ran the verification targets E2E in this sandbox:
Full Makefile audit in 032c8c2:
|
CI pipeline cleanup: remove redundant Splunk tests, enforce zero-leftover Docker cleanup, update golangci-lint to v2, fix stale Makefile references, and keep Jenkinsfile thin by delegating to Makefile targets.
Dependency & Tooling
golangci-lintfrom pinnedv1.57.0tov2.9.0(v2 module path), consistent with whatstorj/cihas--print-resources-usageflag with--verbosefor golangci-lint v2storj-uptoinstall-dev-dependenciesin the Makefileinstall-dev-dependenciescomment: remove stale cURL reference (cURL is not used)Test Suite
integration-splunk-testsentirely (subset of Ceph tests)integration-ceph-teststointegration-all-tests— was previously missing from the aggregate targetZero-Leftover Cleanup
docker compose down --volumes --remove-orphansfirst inintegration-env-cleanstorjlabs/ci:latest,python:3.11-bookworm,golang:${GO_VERSION}(previously leaked)storjlabs/splunk-s3-tests:latestreferenceMakefile Audit & Fixes
integration-env-logs: replace staleintegration-sim-${BUILD_NUMBER}reference (container doesn't exist) withdocker compose logsintegration-ceph-testshelp text for consistency with other integration test targetsJenkinsfile
Verification Path
make verifycorrectly chainslint → cross-vet → test(including testsuite); verified E2E with cross-vet passing all 12 OS/arch combinations and all tests passing💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.