Conversation
amwolff
requested changes
May 18, 2023
| test-testsuite-do: | ||
| go vet ./... | ||
| go test -json=${JSON} -p 16 -parallel 4 -race -short=${SHORT} -timeout 10m -vet=off ./... | ||
| go test -json=${JSON} -cover -coverprofile=.build/coverprofile -p 16 -parallel 4 -race -short=${SHORT} -timeout 10m -vet=off ./... |
Member
There was a problem hiding this comment.
beware, this will overwrite the coverage of the main module
Member
Author
There was a problem hiding this comment.
Can this error be caused by this?
tparse error: no parseable events: call go test with -json flag
Member
Author
|
Closes #275 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
pkg/server: add TestXYZ for XYZCommit Message Body
Closes #1234,Fixes #1234,Resolves #1234orUpdates #1234(the latter if this is not a complete fix) to this commentstorj/gateway-mt, you can use theowner/repo#issue_numbersyntax:Fixes storj/common#1234Related Issue
Code Review Checklist (to be filled out by reviewer)