feat: bump solid and export keyring from uploader#543
Draft
gotjoshua wants to merge 1 commit intostoracha:mainfrom
Draft
feat: bump solid and export keyring from uploader#543gotjoshua wants to merge 1 commit intostoracha:mainfrom
gotjoshua wants to merge 1 commit intostoracha:mainfrom
Conversation
gotjoshua
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the keyring code was double bundled (and at a hefty 200k+ this feels relevant)
Not sure if this strategy is solid (pun intended), but i tried to reexport keyring from uploader.
Initial tests with mapex indicate success, but I need feedback if it actually makes sense,
and it would need testing from the team for bundling and importing in different scenarios
perhaps
export * from '@w3ui/solid-keyring'would make more sense, but i just exported what i need for now.