Skip to content

fix: Use cloneNode for vanilla templates #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thewtex wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Use cloneNode for vanilla templates #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/vanilla/file-upload/src/register.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class RegisterForm extends window.HTMLElement {
}

toggleConfirmation () {
const templateContent = this.confirmationTemplate$.content
const templateContent = this.confirmationTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatTemplateContent(templateContent))
this.signOutButton$ = document.querySelector(SELECTORS.signOutButton)
this.signOutButton$.addEventListener('click', this.signOutHandler)
Expand All @@ -65,7 +65,7 @@ export class RegisterForm extends window.HTMLElement {
}

toggleVerification () {
const templateContent = this.verificationTemplate$.content
const templateContent = this.verificationTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatTemplateContent(templateContent))
this.cancelRegistrationButton$ = document.querySelector(SELECTORS.cancelRegistrationButton)
this.cancelRegistrationButton$.addEventListener('click', this.cancelRegistrationHandler)
Expand Down
10 changes: 5 additions & 5 deletions examples/vanilla/file-upload/src/upload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class UploadFileForm extends window.HTMLElement {
}

async connectedCallback () {
const templateContent = this.uploadFormTemplate$.content
const templateContent = this.uploadFormTemplate$.content.cloneNode(true)
this.replaceChildren(templateContent)
this.handleFileUpload = this.handleFileUpload.bind(this)
this.form$ = document.querySelector(SELECTORS.uploadForm)
Expand Down Expand Up @@ -58,22 +58,22 @@ export class UploadFileForm extends window.HTMLElement {
}

toggleEncoding () {
const templateContent = this.encodingTemplate$.content
const templateContent = this.encodingTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatEncodingTemplateContent(templateContent))
}

toggleUploading () {
const templateContent = this.uploadingTemplate$.content
const templateContent = this.uploadingTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatUploadingTemplateContent(templateContent))
}

toggleUploadComplete () {
const templateContent = this.uploadCompleteTemplate$.content
const templateContent = this.uploadCompleteTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatUploadCompleteTemplateContent(templateContent))
}

toggleUploadError () {
const templateContent = this.uploadErrorTemplate$.content
const templateContent = this.uploadErrorTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatUploadErrorTemplateContent(templateContent))
}

Expand Down
4 changes: 2 additions & 2 deletions examples/vanilla/multi-file-upload/src/register.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class RegisterForm extends window.HTMLElement {
}

toggleConfirmation () {
const templateContent = this.confirmationTemplate$.content
const templateContent = this.confirmationTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatTemplateContent(templateContent))
this.signOutButton$ = document.querySelector(SELECTORS.signOutButton)
this.signOutButton$.addEventListener('click', this.signOutHandler)
Expand All @@ -65,7 +65,7 @@ export class RegisterForm extends window.HTMLElement {
}

toggleVerification () {
const templateContent = this.verificationTemplate$.content
const templateContent = this.verificationTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatTemplateContent(templateContent))
this.cancelRegistrationButton$ = document.querySelector(SELECTORS.cancelRegistrationButton)
this.cancelRegistrationButton$.addEventListener('click', this.cancelRegistrationHandler)
Expand Down
10 changes: 5 additions & 5 deletions examples/vanilla/multi-file-upload/src/upload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,22 +85,22 @@ export class UploadFileForm extends window.HTMLElement {
}

toggleEncoding () {
const templateContent = this.encodingTemplate$.content
const templateContent = this.encodingTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatEncodingTemplateContent(templateContent))
}

toggleUploading () {
const templateContent = this.uploadingTemplate$.content
const templateContent = this.uploadingTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatUploadingTemplateContent(templateContent))
}

toggleUploadComplete () {
const templateContent = this.uploadCompleteTemplate$.content
const templateContent = this.uploadCompleteTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatUploadCompleteTemplateContent(templateContent))
}

toggleUploadError () {
const templateContent = this.uploadErrorTemplate$.content
const templateContent = this.uploadErrorTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatUploadErrorTemplateContent(templateContent))
}

Expand Down Expand Up @@ -133,7 +133,7 @@ export class UploadFileForm extends window.HTMLElement {
}

async connectedCallback () {
const templateContent = this.uploadFormTemplate$.content
const templateContent = this.uploadFormTemplate$.content.cloneNode(true)
this.replaceChildren(templateContent)
this.handleFileUpload = this.handleFileUpload.bind(this)
this.form$ = document.querySelector(SELECTORS.uploadForm)
Expand Down
4 changes: 2 additions & 2 deletions examples/vanilla/sign-up-in/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,14 @@ export class RegisterForm extends window.HTMLElement {
}

toggleConfirmation () {
const templateContent = this.confirmationTemplate$.content
const templateContent = this.confirmationTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatTemplateContent(templateContent))
this.signOutButton$ = document.querySelector(SELECTORS.signOutButton)
this.signOutButton$.addEventListener('click', this.signOutHandler)
}

toggleVerification () {
const templateContent = this.verificationTemplate$.content
const templateContent = this.verificationTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatTemplateContent(templateContent))
this.cancelRegistrationButton$ = document.querySelector(SELECTORS.cancelRegistrationButton)
this.cancelRegistrationButton$.addEventListener('click', this.cancelRegistrationHandler)
Expand Down
4 changes: 2 additions & 2 deletions examples/vanilla/uploads-list/src/register.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class RegisterForm extends window.HTMLElement {
}

toggleConfirmation () {
const templateContent = this.confirmationTemplate$.content
const templateContent = this.confirmationTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatTemplateContent(templateContent))
this.signOutButton$ = document.querySelector(SELECTORS.signOutButton)
this.signOutButton$.addEventListener('click', this.signOutHandler)
Expand All @@ -65,7 +65,7 @@ export class RegisterForm extends window.HTMLElement {
}

toggleVerification () {
const templateContent = this.verificationTemplate$.content
const templateContent = this.verificationTemplate$.content.cloneNode(true)
this.replaceChildren(this.formatTemplateContent(templateContent))
this.cancelRegistrationButton$ = document.querySelector(SELECTORS.cancelRegistrationButton)
this.cancelRegistrationButton$.addEventListener('click', this.cancelRegistrationHandler)
Expand Down