Merged
Conversation
olizilla
reviewed
May 19, 2023
src/handlers/car.js
Outdated
Comment on lines
+85
to
+89
| if (!accept) return { version: 1, order: 'dfs', dups: true } | ||
|
|
||
| const types = accept.split(',').map(s => s.trim()) | ||
| const carType = types.find(t => t.startsWith('application/vnd.ipld.car')) | ||
| if (!carType) return { version: 1, order: 'dfs', dups: true } |
Contributor
There was a problem hiding this comment.
Maybe have a const for the default params, and flip default order to unk
olizilla
approved these changes
May 19, 2023
Contributor
olizilla
left a comment
olizilla
left a comment
There was a problem hiding this comment.
Very nice. good testing. I would maybe switch the last one to simply assert that the expected set of blocks arrives rather than "definitely not dfs", as you comment, dfs is a fine order for unk.
olizilla
reviewed
May 19, 2023
| Accept: 'application/vnd.ipld.car; order=unk' | ||
| } | ||
| }) | ||
| const res = await handleCar(req, env, ctx) |
Contributor
There was a problem hiding this comment.
minor: could verify the fancy content-type header is as expected here on the response
alanshaw
pushed a commit
that referenced
this pull request
May 19, 2023
🤖 I have created a release *beep* *boop* --- ## [3.1.0](v3.0.0...v3.1.0) (2023-05-19) ### Features * implement block order signaling ([#25](#25)) ([1862165](1862165)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates dagula and implements block order signaling via HTTP Accept header as specified in ipfs/specs#412.
It also renames the query param
car-scopetodag-scopeand changes the scope valuefiletoentityas these were updated in ipfs/specs#402.