fix: skip egress tracking if content found in multiple spaces#199
Merged
fix: skip egress tracking if content found in multiple spaces#199
Conversation
travis
approved these changes
Nov 24, 2025
Contributor
|
looks like a test needs to be updated but otherwise g2g! |
Member
Author
Yeah. Just fixed that. Thanks |
fforbeck
pushed a commit
that referenced
this pull request
Nov 25, 2025
🤖 I have created a release *beep* *boop* --- ## [2.34.0](v2.33.0...v2.34.0) (2025-11-25) ### Features * add a stripped down server for debugging ([#196](#196)) ([bd7adb2](bd7adb2)) * bump egress tracking traffic to 5% ([#200](#200)) ([5b97f6f](5b97f6f)) ### Bug Fixes * disable FF_TELEMETRY_ENABLED in wrangler.toml ([#197](#197)) ([b63d3c3](b63d3c3)) * skip egress tracking if content found in multiple spaces ([#199](#199)) ([9a8089f](9a8089f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the same content is found in 2+ different spaces, we now skip egress tracking to avoid ambiguous billing.
The content is still served normally using the first authorized space, but
ctx.spaceis set toundefinedto prevent the egress tracker from recording it.This prevents billing conflicts when content is duplicated across spaces. This problem will be solved later when we enable the
authTokensstrategy.if
spaceisnullorundefined, the Egress Tracking handler won't generate egress events.Closes storacha/project-tracking#602