docs(repo): clarifying relationship to RFC 9535#2777
Open
dret wants to merge 5 commits intostoplightio:developfrom
Open
docs(repo): clarifying relationship to RFC 9535#2777dret wants to merge 5 commits intostoplightio:developfrom
dret wants to merge 5 commits intostoplightio:developfrom
Conversation
frankkilcommins
suggested changes
Feb 12, 2025
Contributor
frankkilcommins
left a comment
frankkilcommins
left a comment
There was a problem hiding this comment.
Almost good to go.
The spectral repo also follows conventional commits and similar type of linting for PRs. Thus you'll need to change the PR title (and perhaps commit messages) to pass the linting checks (e.g. docs(repo): clarifying relationship to RFC 9535)
dret
changed the title
Contributor
|
@dret Can you please take a stab at amending the commit message to follow conventional commits. That would fix the pipeline. |
|
Hey @dret Friendly nudge for an update to the commit message to resolve the CI failure |
Contributor
Author
Done. Thanks for the nudge. |
Contributor
Author
|
And even doner now. Seems like I managed to violate the style guide in multiple ways... |
Co-authored-by: Frank Kilcommins <fkilcommins@gmail.com>
YOU54F
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses #2773 .