Add optional key length to OpenSSLHelper#26
Open
markokeeffe wants to merge 4 commits intostonemax:masterfrom
Open
Add optional key length to OpenSSLHelper#26markokeeffe wants to merge 4 commits intostonemax:masterfrom
markokeeffe wants to merge 4 commits intostonemax:masterfrom
Conversation
Added a $bits argument to OpenSSLHelper::generateCSR(). Mainly because I'd love to use this package to create certificates that can be used in Amazon CloudFront, but for some reason, certificates uploaded into the AWS Certificate Manager must have a key length of 2048 bits in order to work with CloudFront.
- Allow 'bits' argument on getCSR method
- Added constants for order status
McJoppy
pushed a commit
to silverstripe-platform/acme2
that referenced
this pull request
Sep 29, 2021
Given our requirements have also changed default to 2048. Based of PR in parent repo (stonemax#26)
McJoppy
pushed a commit
to silverstripe-platform/acme2
that referenced
this pull request
Sep 29, 2021
Given our requirements have also changed default to 2048. Based of PR in parent repo (stonemax#26)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a $bits argument to OpenSSLHelper::generateCSR(). Mainly because I'd love to use this package to create certificates that can be used in Amazon CloudFront, but for some reason, certificates uploaded into the AWS Certificate Manager must have a key length of 2048 bits in order to work with CloudFront.