Skip to content

Always ensure application-manager ManagedServiceAccount exists#1490

Merged
xiangjingli merged 1 commit intomainfrom
ensureMSA
Mar 24, 2026
Merged

Always ensure application-manager ManagedServiceAccount exists#1490
xiangjingli merged 1 commit intomainfrom
ensureMSA

Conversation

@xiangjingli
Copy link
Copy Markdown
Contributor

  • I have taken backward compatibility into consideration.

https://redhat.atlassian.net/browse/ACM-31416

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 23, 2026

@xiangjingli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 514b31a link true /test sonarcloud

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xiangjingli xiangjingli requested a review from mikeshng March 23, 2026 21:33
Copy link
Copy Markdown
Contributor

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mikeshng,xiangjingli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiangjingli xiangjingli merged commit 5b8bc73 into main Mar 24, 2026
9 of 11 checks passed
@xiangjingli xiangjingli deleted the ensureMSA branch March 24, 2026 14:27
@xiangjingli
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-2.16

@openshift-cherrypick-robot
Copy link
Copy Markdown

@xiangjingli: new pull request created: #1518

Details

In response to this:

/cherry-pick release-2.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants