Skip to content

chore: update js-lingui-solid submodule pointer for Windows compatibility#952

Open
Cynrode wants to merge 2 commits intostoatchat:mainfrom
Cynrode:fix/windows-lingui-prepare
Open

chore: update js-lingui-solid submodule pointer for Windows compatibility#952
Cynrode wants to merge 2 commits intostoatchat:mainfrom
Cynrode:fix/windows-lingui-prepare

Conversation

@Cynrode
Copy link
Copy Markdown

@Cynrode Cynrode commented Feb 28, 2026

What

Updates the js-lingui-solid submodule pointer to the latest commit that includes Windows-compatible behavior.

  • Removes the WSL requirement for building the submodule.
  • Ensures pnpm install works correctly on Windows.
  • Updates the submodule pointer in stoat-for-web without modifying other repositories.

Why

Building or installing on Windows required WSL, which caused setup friction for contributors on native Windows environments. This changes ensures a smoother setup and cross-platform consistency while keeping the PR minimal and reviewable.

Testing

  • Verified that pnpm install succeeds on Windows without errors.
  • Submodule changes are limited tot the pointer update; no other files in stoat-for-web were modified.

@Cynrode
Copy link
Copy Markdown
Author

Cynrode commented Feb 28, 2026

CI Failure Explanation

The current CI failures are caused by the submodule commit not being reachable from the canonical repo yet, not by any issue with the changes themselves.

fatal: remote error: upload-pack: not our ref 0118ffccfe2b49f8d6d6c6cff437c4529ad4d613
fatal: Fetched in submodule path 'packages/js-lingui-solid', but it did not contain 0118ffccfe2b49f8d6d6c6cff437c4529ad4d613.

The submodule pointer references a commit that currently only exists in my fork. The fix lives in a separate PR against stoatchat/javascript-lingui-solid:

➡️ stoatchat/javascript-lingui-solid#1 — adds prepare scripts to both babel-plugin-extract-messages and babel-plugin-lingui-macro so that dist/ builds automatically on pnpm install, removing the Windows/WSL requirement.

Once that PR is merged, I can update the submodule pointer here in the canonical commit and CI should pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants