fix(stoatchat#754): Add white margin to QR code for 2FA#773
Open
mille3sansDouze wants to merge 1 commit intostoatchat:mainfrom
Open
fix(stoatchat#754): Add white margin to QR code for 2FA#773mille3sansDouze wants to merge 1 commit intostoatchat:mainfrom
mille3sansDouze wants to merge 1 commit intostoatchat:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #754
Adds a white margin wrapper around the QR code to ensure proper scanning compatibility with authenticator apps like Aegis, ZXing, and standard camera apps.
Changes
QrWrapperstyled component with white background and padding (1rem)Qrcomponent insideQrWrapperTesting
The QR code should now be scannable by all authenticator apps without needing manual editing in image editors.
Related
Closes #754