fix: Incorrect password field on account creation#757
Open
SandPoot wants to merge 1 commit intostoatchat:mainfrom
Open
fix: Incorrect password field on account creation#757SandPoot wants to merge 1 commit intostoatchat:mainfrom
SandPoot wants to merge 1 commit intostoatchat:mainfrom
Conversation
This doesn't seem like the correct behavior Signed-off-by: SandPoot <43283559+SandPoot@users.noreply.github.com>
acidtib
suggested changes
Feb 17, 2026
| </FlowTitle> | ||
| <Form onSubmit={create} captcha={CONFIGURATION.HCAPTCHA_SITEKEY}> | ||
| <Fields fields={["email", "password"]} /> | ||
| <Fields fields={["email", "new-password"]} /> |
There was a problem hiding this comment.
this will break the api call with 422: Unprocessable Entity since the request sends password not new-password
to complete this pr we would need something like
L66-71
// Map field types to form field names
// "new-password" should submit as "password" for API compatibility
const getFieldName = (field: Field) => {
if (field === "new-password") return "password";
return field;
};
L85
name={getFieldName(field)}
in packages/client/components/auth/src/flows/Form.tsx
Author
There was a problem hiding this comment.
I'm sorry, i'll have to check this later, ideally, i wouldn't want stuff to be hacky like this, but if that's fine i'll just apply it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't be too cruel with me, i was just attempting to check out stoat and noticed that trying to create an account asks you to "Enter your current password" and doesn't have password suggesting.
I have replaced "password" with "new-password" according to the file Form.tsx, this is not AI-assisted, i've done it raw on my web browser.