Fix return value from RdSeed_cpuid()#9
Open
blubberdiblub wants to merge 1 commit intostillson:masterfrom
Open
Conversation
The function returned `info[1]` (which is the content of the `ebx` register) instead of `0` when it detected that _rdseed_ is unavailable. This is likely a remnant from an earlier iteration of the code. While it is unlikely that it will show up as bug (all of the bits of `ebx` would have to be cleared, except bit #0 which would have to be set) due to the calling function comparing the return value explicitly with 1, it's still better to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function returned
info[1](which is the content of theebxregister) instead of
0when it detected that rdseed is unavailable.This is likely a remnant from an earlier iteration of the code.
While it is unlikely that it will show up as bug (all of the bits of
ebxwould have to be cleared, except bit #0 which would have to beset) due to the calling function comparing the return value explicitly
with 1, it's still better to fix it.