Skip to content

Conversation

@LonelyCat124
Copy link
Collaborator

First commit and implementation.

I think this will need potentially review from both Andy/Sergi and Joerg as we'll need to check that I haven't broken anything while updating the Transformations/PsyDataNode options.

@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (ceee854) to head (c8beae5).
Report is 123 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3004   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files         365      365           
  Lines       51853    51924   +71     
=======================================
+ Hits        51806    51877   +71     
  Misses         47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LonelyCat124
Copy link
Collaborator Author

Outside of coverage issues, I need to still check if the documentation is up-to-date

@LonelyCat124
Copy link
Collaborator Author

Ready for a look now @arporter @sergisiso @hiker . Before merging at least it would be good to have it run with some production extraction use-cases to ensure I've not broken anything (the tests all pass but user usage might be different).

@sergisiso
Copy link
Collaborator

@LonelyCat124 As we discussed, test regarding extraction are temporarily marked xfail in master. So we won't be able to test this properly until #2948 is merged, I will mark this PR as blocked until then.

@sergisiso sergisiso added Blocked An issue/PR that is blocked by one or more issues/PRs. and removed ready for review labels May 28, 2025
@sergisiso sergisiso changed the title (Closes #2981) disable exit profiling Convert PSyDataTrans options to kwargs Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked An issue/PR that is blocked by one or more issues/PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants