-
Notifications
You must be signed in to change notification settings - Fork 32
Convert PSyDataTrans options to kwargs #3004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3004 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 365 365
Lines 51853 51924 +71
=======================================
+ Hits 51806 51877 +71
Misses 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Outside of coverage issues, I need to still check if the documentation is up-to-date |
…e into 2981_disable_exit_profiling
|
Ready for a look now @arporter @sergisiso @hiker . Before merging at least it would be good to have it run with some production extraction use-cases to ensure I've not broken anything (the tests all pass but user usage might be different). |
|
@LonelyCat124 As we discussed, test regarding extraction are temporarily marked xfail in master. So we won't be able to test this properly until #2948 is merged, I will mark this PR as blocked until then. |
First commit and implementation.
I think this will need potentially review from both Andy/Sergi and Joerg as we'll need to check that I haven't broken anything while updating the Transformations/PsyDataNode options.