Skip to content
This repository was archived by the owner on Dec 30, 2025. It is now read-only.

Add standalone audience response HTML page#71

Open
stevetodman wants to merge 1 commit intoclaude/add-dependabot-011CUuuS9RfZqAhUaWSZCqADfrom
codex/make-html-document-standalone
Open

Add standalone audience response HTML page#71
stevetodman wants to merge 1 commit intoclaude/add-dependabot-011CUuuS9RfZqAhUaWSZCqADfrom
codex/make-html-document-standalone

Conversation

@stevetodman
Copy link
Owner

Summary

  • add a standalone HTML file that hosts the audience response system outside of the existing app structure

Testing

  • npm run test

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +870 to +873
const submitResponse = () => {
if (selectedAnswer) {
db.submitResponse(sessionId, { answer: selectedAnswer });
setHasSubmitted(true);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Only mark submission successful after Firebase write succeeds

In the student view, the submit handler sets hasSubmitted to true immediately after invoking db.submitResponse without awaiting or checking the returned promise. If the network request fails or the Firebase write is rejected, the UI still shows “Response Submitted” and disables further interaction, so the vote is silently dropped and cannot be retried. Consider awaiting the promise and only transitioning to the success state on fulfillment (showing an error and leaving hasSubmitted false on rejection) to keep the response counts accurate.

Useful? React with 👍 / 👎.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant