fix: critical build and dependency configuration#50
fix: critical build and dependency configuration#50stevenschling13 wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates project configuration to stabilize the development environment and prepare for production readiness. The changes ensure consistent tooling versions and remove development-time flexibility flags from CI.
- Locks pnpm to specific version 9.15.9 (matching packageManager field)
- Enforces strict CI checks (frozen lockfile, mandatory typecheck)
- Updates environment example with placeholders for upcoming integrations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Removes typescript-eslint dependency |
| .github/workflows/ci.yml | Locks pnpm version, enables frozen lockfile, removes typecheck bypass |
| .env.example | Updates port default and adds placeholder env vars for Notion and AI integrations |
| "tsx": "^4.19.0", | ||
| "typescript": "^5.6.3", | ||
| "typescript-eslint": "^8.46.2", | ||
| "vitest": "^2.1.3" |
There was a problem hiding this comment.
Removing the typescript-eslint package breaks the build. The eslint.config.js file imports this package with import tseslint from 'typescript-eslint'. Either keep this dependency or refactor eslint.config.js to use only the individual @typescript-eslint/* packages.
| "vitest": "^2.1.3" | |
| "vitest": "^2.1.3", | |
| "typescript-eslint": "^8.12.0" |
|
|
||
| # Secret used to validate incoming webhook signatures | ||
| # Server | ||
| PORT=3000 |
There was a problem hiding this comment.
The default PORT is changed from 8080 to 3000, but the coding guidelines and documentation specify the default port is 8080. This inconsistency should be addressed by either keeping 8080 or updating the documentation to reflect the new default.
| PORT=3000 | |
| PORT=8080 |
Problem
tsxin dependencies instead of devDependencies.typescript-eslintentry risked resolver confusion..env.example.packageManager.Changes
pnpm install --frozen-lockfile|| truefrom typechecktsxto devDependencies; remove duplicatetypescript-eslint.env.example(PORT, HMAC_SECRET, Notion/AI placeholders)pnpm-lock.yaml(pnpm 9, Node 20)Results
Risks
Notes
src/routes/analyze.ts..jspreserved.https://chatgpt.com/codex/tasks/task_e_6907a63d7f58832c811737e4e745633f