fix: critical build and dependency configuration#48
fix: critical build and dependency configuration#48stevenschling13 wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the typescript-eslint package as a direct dependency and strengthens the CI pipeline configuration. The project already has @typescript-eslint/eslint-plugin and @typescript-eslint/parser installed, making the typescript-eslint wrapper package redundant. Additionally, CI configuration is improved to enforce stricter checks.
Key changes:
- Removes redundant
typescript-eslintdependency (functionality already provided by direct TypeScript ESLint packages) - Enables frozen lockfile mode in CI to ensure reproducible builds
- Removes the temporary
|| truefallback from typecheck to enforce type safety
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Removes redundant typescript-eslint dependency from devDependencies |
| pnpm-lock.yaml | Updates lockfile to reflect removal of typescript-eslint package and its snapshots |
| .github/workflows/ci.yml | Enables frozen lockfile installation and makes typecheck failure block CI |
| .env.example | Reorganizes environment variables and adds placeholders for future Notion and AI integrations |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "eslint": "^9.13.0", | ||
| "tsx": "^4.19.0", | ||
| "typescript": "^5.6.3", | ||
| "typescript-eslint": "^8.46.2", | ||
| "vitest": "^2.1.3" |
There was a problem hiding this comment.
Restore typescript-eslint dependency
The ESLint config still imports the typescript-eslint meta package (import tseslint from "typescript-eslint"; in eslint.config.js), but this commit removes that package from devDependencies. After this change, pnpm install no longer installs typescript-eslint, so pnpm run lint and the CI workflow will fail with “Cannot find module 'typescript-eslint'”. Re‑introducing the dependency (or refactoring the config to avoid it) is required for linting to work.
Useful? React with 👍 / 👎.
Problem
typescript-eslintwas redundantly listed alongside the scoped packages, causing an unnecessary install target inpackage.jsonand the lockfile.--frozen-lockfile=falseand ignored type-check failures, which masked dependency drift and type errors.Approach
.env.examplecovering current server settings and placeholders for future Notion/AI credentials.typescript-eslintmeta-package frompackage.jsonand synchronizedpnpm-lock.yamlaccordingly.--frozen-lockfileand to surface type-check failures.Tests
npx vitest --runPerformance (if applicable)
Risks & Rollback
Follow-up
Links
https://chatgpt.com/codex/tasks/task_e_69079d8121d4832c8f2f2c383cbd3283