Skip to content

fix: critical build and dependency configuration#48

Open
stevenschling13 wants to merge 1 commit intomainfrom
codex/conduct-comprehensive-repository-audit-stvz7g
Open

fix: critical build and dependency configuration#48
stevenschling13 wants to merge 1 commit intomainfrom
codex/conduct-comprehensive-repository-audit-stvz7g

Conversation

@stevenschling13
Copy link
Owner

Problem

  • The repository was missing a shareable environment template for required secrets and upcoming integrations.
  • typescript-eslint was redundantly listed alongside the scoped packages, causing an unnecessary install target in package.json and the lockfile.
  • The CI workflow used --frozen-lockfile=false and ignored type-check failures, which masked dependency drift and type errors.

Approach

  • Added a comprehensive .env.example covering current server settings and placeholders for future Notion/AI credentials.
  • Removed the redundant typescript-eslint meta-package from package.json and synchronized pnpm-lock.yaml accordingly.
  • Updated the CI workflow to honor the existing lockfile with --frozen-lockfile and to surface type-check failures.

Tests

  • npx vitest --run

Performance (if applicable)

  • Not applicable.

Risks & Rollback

  • Minimal risk; reverting the commit restores the previous dependency list and CI flags.

Follow-up

  • None.

Links

  • Related task instructions in the agent prompt.

https://chatgpt.com/codex/tasks/task_e_69079d8121d4832c8f2f2c383cbd3283

Copilot AI review requested due to automatic review settings November 2, 2025 18:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the typescript-eslint package as a direct dependency and strengthens the CI pipeline configuration. The project already has @typescript-eslint/eslint-plugin and @typescript-eslint/parser installed, making the typescript-eslint wrapper package redundant. Additionally, CI configuration is improved to enforce stricter checks.

Key changes:

  • Removes redundant typescript-eslint dependency (functionality already provided by direct TypeScript ESLint packages)
  • Enables frozen lockfile mode in CI to ensure reproducible builds
  • Removes the temporary || true fallback from typecheck to enforce type safety

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Removes redundant typescript-eslint dependency from devDependencies
pnpm-lock.yaml Updates lockfile to reflect removal of typescript-eslint package and its snapshots
.github/workflows/ci.yml Enables frozen lockfile installation and makes typecheck failure block CI
.env.example Reorganizes environment variables and adds placeholders for future Notion and AI integrations
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 28 to 31
"eslint": "^9.13.0",
"tsx": "^4.19.0",
"typescript": "^5.6.3",
"typescript-eslint": "^8.46.2",
"vitest": "^2.1.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore typescript-eslint dependency

The ESLint config still imports the typescript-eslint meta package (import tseslint from "typescript-eslint"; in eslint.config.js), but this commit removes that package from devDependencies. After this change, pnpm install no longer installs typescript-eslint, so pnpm run lint and the CI workflow will fail with “Cannot find module 'typescript-eslint'”. Re‑introducing the dependency (or refactoring the config to avoid it) is required for linting to work.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant