fix: remove legacy-peer-deps workaround#86
Merged
stevenferey merged 1 commit intodevelopfrom Mar 9, 2026
Merged
Conversation
Remove `.npmrc` files (root and backend) that globally set `legacy-peer-deps=true`. This was originally needed because react-helmet-async v2 didn't declare React 19 support, now resolved with v3.0.0. Add a targeted `overrides` in package.json for the remaining eslint-plugin-react-hooks / ESLint 10 peer dep conflict, which will be resolved once a stable release supports ESLint 10. Closes #67 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.npmrc(racine + backend) qui forçaientlegacy-peer-deps=trueglobalementpackage-lock.json:react-helmet-asyncpasse de 2.0.5 à 3.0.0 (support React 19 natif)overridesciblé danspackage.jsonpour le confliteslint-plugin-react-hooks/ ESLint 10, en attendant une release stable du pluginCloses #67
Test plan
npm installsans erreur ni conflit de peer depsnpm ls react-helmet-async→ 3.0.0npm run build→ compile sans erreurnpm run type-check→ pas d'erreurs TypeScriptnpm run lint→ pas de régressions (warnings pré-existants uniquement)backend/npm install→ sans erreur🤖 Generated with Claude Code