Skip to content

RefractiveBRDF #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
giogala wants to merge 69 commits into
base: main
Choose a base branch
from
Draft

RefractiveBRDF #39

giogala wants to merge 69 commits into from

Conversation

@giogala
Copy link
Collaborator

@giogala giogala commented Jun 17, 2025 •
edited
Loading

Try to implement a RefractiveBRDF ruled by Fresnel's Law for TE polarization. The necessary is:

  • declare new BRDF type
  • add r_ind member to Ray in order to remember the medium of propagation
  • modify Ray calls for keeping consistency
  • add tests and docstrings
  • modify README.md and CHANGELOG.md

giogala and others added 30 commits May 28, 2025 12:39
@giogala
Open interpreter
fbca25c
@stevelonny
Add methods for InputStream, add tests for InputStream
02c7037
@stevelonny
Add dosctrings to InputStram
e0813d4
@MichiB2600
Implement tokens and read_token with tests
b1c3903
@stevelonny
Merge remote-tracking branch 'origin/main' into interpreter
a711ffe
@MichiB2600
Rename interpreter.jl -> lexer.jl + correcting small bug
c7a31d5
@MichiB2600
Merge branch 'interpreter' of github.com:stevelonny/jujutracer into i…
fb2348a 
…nterpreter
@MichiB2600
Rename interpreter -> lexer also in jujutracer.jl + modify test for bug
0c2cc78
@MichiB2600
Add parser.jl for syntactic and lexical and semantic analysis
11881be
@MichiB2600
Implement expected_* methods with tests
249518f
@stevelonny
Add parse_vector and parse_color functions with tests
9bb74a3
@stevelonny
Add parse_pigment with functions
d524121
@stevelonny
Add parse_brdf with tests, add parse_material (need test!)
b5cbff3
@stevelonny
Add test for parse_material
b1981a9
@stevelonny
Merge branch 'main' into interpreter
ea9833e
@stevelonny
Add unread_token! with test
00079e5
@stevelonny
Add parse_transformation with tests
288c6f4
@stevelonny
Add parse_sphere
7c61d36
@stevelonny
Add tests for parse_sphere, add parse_plane with tests
948c05d
@stevelonny
Add parse_camera with tests
e1f0f56
@stevelonny
Add parse_scene with tests
020dc63
@stevelonny
Add basic interpreter.jl for parsing and costructing a scene
0b1fb8b
@stevelonny
Finish interpreter script, add some demo files
b00f1ac
@stevelonny
Expand docstrings, add _ to private lexer/parser funcs
d25cadf
@stevelonny
up CHANGELOG
e9f35b7
@stevelonny
Remove _parse_sphere and _parse_plane in favour of parametric _parse_…
dfc8cd5 
…shape
@stevelonny
Add _parse_triangle and _parse_parallelogram with tests
c512f8f
@stevelonny
Add to parse_scene triangle and parallelogram, expand test for parse_…
def0d02 
…scene for all shapes
@stevelonny
Merge remote-tracking branch 'origin/main' into interpreter
c28cfcf
@stevelonny
Add _parse_lightsource and _parse_spotlight with tests, add light sou…
cbab99e 
…rces to demo.txt and demopath.txt
@giogala
Copy link
Collaborator Author

giogala commented Jun 17, 2025

After the correction I created the following image:
refractive

giogala and others added 22 commits June 17, 2025 17:39
@giogala
Update CHANGELOG.md
1206818
@giogala
Modify csg parsing and write demoCSG.txt
91afd47
@giogala
Adjust test in order to match _parse_csg_operation changes
9a9f084
@stevelonny
Build bvh only for mesh objs, add tree.txt scene
424e1bf
@stevelonny
Merge branch 'interpreter' of https://github.com/stevelonny/jujutracer …
4608c54 
…into interpreter
@stevelonny
divide function in interpreter.jl entry point
0c69688
@giogala
Begin writing documentation
d834c43
@giogala
Merge branch 'interpreter' of github.com:stevelonny/jujutracer into i…
347e958 
…nterpreter
@stevelonny
add parsing overriden variables from command line
00d8462
@stevelonny
Merge branch 'interpreter' of https://github.com/stevelonny/jujutracer …
5195e65 
…into interpreter
@stevelonny
Add docstring to typeCSG
a0244ac
@giogala
Move the documentation in docs/src/index.md
b4b7066
@giogala
Merge branch 'interpreter' of github.com:stevelonny/jujutracer into i…
ad88c15 
…nterpreter
@giogala
Merge interpreter (#28) into newbrdf
70f3808
@stevelonny
Move scripts into folder
f9cda33
@giogala
Include refraction in parser and modified R index computation
a3e1ca2
@giogala
Create cornellbox.txt and modify erroneous normals computation
7329bc5
@stevelonny
Add repl usage in the docs, remove refs
0b22759
@stevelonny
Merge branch 'interpreter' of https://github.com/stevelonny/jujutracer …
42d791d 
…into interpreter
@giogala
Modify cornellbox.txt
5bf75f6
@giogala
Merge branch 'interpreter' of github.com:stevelonny/jujutracer into i…
0d96bc2 
…nterpreter
@giogala
Merge branch 'interpreter' into newbrdf
40d83af
@giogala
Copy link
Collaborator Author

giogala commented Jun 19, 2025

After several tries I understood the constrains of the equation I was taking inspiration from:

  • $$w_i$$ is gettin' out and not into the point of intersection
  • $$w_i$$ is normalized

I modified my implementation taking in account these hypothesis and obtained a physical behavior!
path_refr_4

@giogala
Copy link
Collaborator Author

giogala commented Jun 20, 2025

Finally achieved to generate the animation of an arrow being refracted by a glass. Need to thanks @daviderivaa for the idea. Here you are!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@giogala giogala

Labels

enhancement New feature or request

Projects

JuJutracer To Do List
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@giogala @stevelonny @MichiB2600