Avoid duplicates when storing and unstoring#4
Open
Toranks wants to merge 1 commit intostevecotton:masterfrom
Open
Avoid duplicates when storing and unstoring#4Toranks wants to merge 1 commit intostevecotton:masterfrom
Toranks wants to merge 1 commit intostevecotton:masterfrom
Conversation
Toranks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do you think about this? It's the safest way I've thought of. It first checks that it is not already in nfw_wounded to avoid duplicates, in case some scenario invokes the same unit id repeatedly.
And then, when doing unstore on the victory event, it is checked that the saved unit was not brought back to life by other methods before the victory event, to avoid conflicts with special events of some scenarios.
This resolves #3 and other potential conflicts.