Conversation
…ngName tests to test_objects
…ferences between parsed and original files
|
stevearc
left a comment
There was a problem hiding this comment.
I'm happy to merge this, but please ensure that the tests and CI are passing first
Working on those fixes. I'll let you know as soon as they're ready. The tests pass when I run them locally so I'm relying on the github workflows to test my changes |
* Fix 2 * Update formatting * Formatting fix 2 * More formatting * Fixes 100% --------- Co-authored-by: DougVanny <douglas.vanny@proton.me>
|
@stevearc Should be good to go now |
|
Or not. I'll take a look at the coverage checks. That check didn't run on my fork for some reason |
|
Awesome, thanks for the PR! |
This PR contains a series of changes to bring this parser up to date with new additions made to Godot (up to 4.6)
Adds support for typed Arrays
Array[type]([...])Adds support for typed Dictionaries
Dictionary[key_type,value_type]({...})Adds support for StringNames
&"..."Adjusts string output of some types, removing unnecessary whitespaces and matching how Godot 4.6 saves scenes and resources
Adds support for all Variant types as dictionary keys, matching what is currently possible with Godot
Adds tests for all changes listed above
Supersedes Add support for typed arrays and match Godot 4 formatting. #13 Remove GDObject serialization white spaces #17 Add support to typed arrays and string names #18