Pre-setting FileObject._is_folder for performance #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The listdir function returns two values, one for directory names and one for file names. These are lists of strings and thus do not have a delete method. Instead of trying to delete each array, we loop through them to build keys that we can delete.
…or_gcs Fixes issues with old methods in GoogleStorageMixin
Fix rmtree method of S3BotoStorageMixin
…ication Fix cs specification that is breaking compilemessages command
Fix issues with old methods in GoogleStorageMixin
This is especially useful for `filebrowser_safe.views.browse`, in which we already know whether an object is folder or not before initializing the FileObject instance. PS: I am using S3 storage backend, I can observe about 3x performance optimization.
jerivas
force-pushed
the
master
branch
2 times, most recently
from
e04a9c1 to
c7eceb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially useful for
filebrowser_safe.views.browse,in which we already know whether an object is folder or not
before initializing the FileObject instance.
PS: I am using S3 storage backend, I can observe about 3x performance optimization.