Skip to content

fix: resolve clippy warnings in explain and cli tests #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nh13 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve clippy warnings in explain and cli tests #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions src/explain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,10 @@ mod tests {

#[test]
fn test_config_section_for_model_with_config() {
let mut cfg = CshipConfig::default();
cfg.model = Some(crate::config::ModelConfig::default());
let cfg = CshipConfig {
model: Some(crate::config::ModelConfig::default()),
..Default::default()
};
assert_eq!(config_section_for("cship.model", &cfg), "[cship.model]");
}

Expand Down Expand Up @@ -438,11 +440,13 @@ mod tests {

#[test]
fn test_error_hint_for_disabled_module_returns_disabled_text() {
let mut cfg = CshipConfig::default();
cfg.model = Some(ModelConfig {
disabled: Some(true),
let cfg = CshipConfig {
model: Some(ModelConfig {
disabled: Some(true),
..Default::default()
}),
..Default::default()
});
};
let ctx = Context {
model: Some(Model {
display_name: Some("Sonnet".to_string()),
Expand All @@ -466,11 +470,13 @@ mod tests {

#[test]
fn test_is_disabled_returns_true_for_disabled_model() {
let mut cfg = CshipConfig::default();
cfg.model = Some(ModelConfig {
disabled: Some(true),
let cfg = CshipConfig {
model: Some(ModelConfig {
disabled: Some(true),
..Default::default()
}),
..Default::default()
});
};
assert!(
is_disabled("cship.model", &cfg),
"is_disabled should return true when model.disabled = Some(true)"
Expand Down
4 changes: 2 additions & 2 deletions tests/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ fn test_context_window_subfields_render_correctly() {
assert!(output.status.success());
let stdout = String::from_utf8_lossy(&output.stdout);
// Output format: "8 92 200000\n" — verify each value appears as a space-delimited token
let tokens: Vec<&str> = stdout.trim().split_whitespace().collect();
let tokens: Vec<&str> = stdout.split_whitespace().collect();
assert_eq!(
tokens.len(),
3,
Expand Down Expand Up @@ -445,7 +445,7 @@ fn test_context_window_total_tokens_render_correctly() {
.unwrap();
assert!(output.status.success());
let stdout = String::from_utf8_lossy(&output.stdout);
let tokens: Vec<&str> = stdout.trim().split_whitespace().collect();
let tokens: Vec<&str> = stdout.split_whitespace().collect();
assert_eq!(tokens.len(), 2, "expected 2 tokens: {stdout:?}");
assert_eq!(
tokens[0], "15234",
Expand Down