fix(installer): fix Windows installer bugs found during live testing#144
Merged
stephenleo merged 1 commit intomainfrom Mar 28, 2026
Merged
fix(installer): fix Windows installer bugs found during live testing#144stephenleo merged 1 commit intomainfrom
stephenleo merged 1 commit intomainfrom
Conversation
- Replace em dashes with ASCII hyphens to prevent PowerShell 5.1
encoding bug (UTF-8 bytes misread as Windows-1252 curly quotes,
breaking elseif syntax)
- Change install location from %LOCALAPPDATA%\Programs\cship\ to
~/.local/bin so the binary is on Git Bash PATH without session restart
- Fix settings.json path: was %APPDATA%\Claude\settings.json, correct
path is ~/.claude/settings.json on all platforms including Windows
- Fix statusLine format: was "statusline":"cship", correct format is
"statusLine":{"type":"command","command":"cship"}
- Auto-create ~/.local/bin and silently add to user PATH if missing
- Show full settings.json path in all installer/uninstaller messages
- Remove Windows-specific APPDATA branch from uninstall.rs (now uses
same home-relative path as all other platforms)
- Update README, docs, explain.rs hints, and install.sh manual hint
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.ps1were being misread by PowerShell 5.1 (UTF-8 bytes → Windows-1252 curly quotes → broken string parsing →elseifunrecognized). Replaced with ASCII hyphens.%LOCALAPPDATA%\Programs\cship\to~/.local/binso the binary is on Git Bash PATH immediately without a session restart. Directory is auto-created if missing; added to user PATH silently if not already present.settings.jsonpath: was%APPDATA%\Claude\settings.json(Roaming); correct path is~/.claude/settings.jsonon all platforms including Windows. Fixed ininstall.ps1,uninstall.rs,README.md, anddocs/index.md.statusLineformat: was"statusline": "cship"(wrong key, wrong value type); correct format is"statusLine": {"type": "command", "command": "cship"}. Fixed ininstall.ps1,uninstall.rs(key lookup + messages + tests),install.shmanual hint, and allexplain.rsremediation hints.settings.jsonwhen updated.APPDATAbranch inuninstall.rsand its test deleted; all platforms now usehome.join(".claude/settings.json").Test plan
.\install.ps1on a clean Windows machine — binary lands in~/.local/bin,~/.local/binadded to PATH,~/.claude/settings.jsonwritten with correctstatusLineobjectwhich cshipfinds the binary in a new Git Bash sessioncship uninstall— confirms correctsettings.jsonpath in output, removesstatusLinekeycargo test— all tests pass🤖 Generated with Claude Code