feat(ci): add Windows to CI and release pipeline#140
Merged
stephenleo merged 3 commits intomainfrom Mar 28, 2026
Merged
Conversation
Add windows-latest to the ci.yml and release.yml test matrices, and add x86_64-pc-windows-msvc and aarch64-pc-windows-msvc build targets to release.yml. Update Rename/Validate binary steps to handle .exe suffix on Windows; use glob upload path so both Linux and Windows assets are picked up correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The original change removed the `file` validation command for all targets when it only needed to be skipped on Windows (where `file` is unavailable). This restores it conditionally for Linux/macOS to catch cross-compilation architecture mismatches. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
On Windows the function uses APPDATA instead of HOME to locate settings.json, so the non-APPDATA test was writing the file to the wrong path and always hitting the "not found — skipping" branch. Windows-specific behaviour is already covered by test_remove_statusline_uses_appdata_on_windows. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-latest) runner to the CI matrix so Windows builds are validated on every PRcship-x86_64-pc-windows-msvc.exebinary alongside existing Linux and macOS targetsfilecommand validation for non-Windows binaries to keep integrity checks intact on Linux/macOSTest plan
cship-x86_64-pc-windows-msvc.exeasset on av*tag push🤖 Generated with Claude Code