Add support for an optional localUdpPort config entry for NAT users and ...#68
Add support for an optional localUdpPort config entry for NAT users and ...#68rassilon wants to merge 1 commit intostephen304:masterfrom
Conversation
…nd pass it to goscrape.
|
I don't think I have support for this yet in goscrape? I'll have to make sure it all works together. |
|
I think I want to make this as a config struct so that it can be left empty for those who don't need it. |
|
Are you saying you want goscrape to have a config struct to pass in instead of just the individual param? If so, I can try and muck something up for that. Bill |
|
Maybe. I don't want it to complicate the use for those who don't need it. Perhaps a post initialization function to set config values. This won't make it into the release I'm doing today or tomorrow so it's not super urgent. Maybe bulk = NewBulk([]trackers) I'll return to this later. |
|
No worries. I don't think you can call bulk.SetLocalUDP() there, since localUdpPort needs to get passed to goscrape.asyncSession from NewBulk(). |
|
Ah, I see what you mean. Here's where I'm really wishing that, for organizational purposes, go had function overloading. I'll return to this in a bit. |
|
I'm a bit occupied with other things at the moment - if you want to make a config struct and implement that I can merge that in |
...pass it to goscrape.
I didn't supply the config.json edit since my local .json file is the one I use to run bitcannon with.
Bill