Skip to content
This repository was archived by the owner on Aug 27, 2020. It is now read-only.

Add support for an optional localUdpPort config entry for NAT users and ...#68

Open
rassilon wants to merge 1 commit intostephen304:masterfrom
rassilon:localUdpPort
Open

Add support for an optional localUdpPort config entry for NAT users and ...#68
rassilon wants to merge 1 commit intostephen304:masterfrom
rassilon:localUdpPort

Conversation

@rassilon
Copy link

...pass it to goscrape.

I didn't supply the config.json edit since my local .json file is the one I use to run bitcannon with.

Bill

@stephen304
Copy link
Owner

I don't think I have support for this yet in goscrape? I'll have to make sure it all works together.

@stephen304
Copy link
Owner

I think I want to make this as a config struct so that it can be left empty for those who don't need it.

@rassilon
Copy link
Author

Are you saying you want goscrape to have a config struct to pass in instead of just the individual param?

If so, I can try and muck something up for that.

Bill

@stephen304
Copy link
Owner

Maybe. I don't want it to complicate the use for those who don't need it. Perhaps a post initialization function to set config values. This won't make it into the release I'm doing today or tomorrow so it's not super urgent.

Maybe bulk = NewBulk([]trackers)
bulk.SetLocalUDP(int)

I'll return to this later.

@rassilon
Copy link
Author

No worries. I don't think you can call bulk.SetLocalUDP() there, since localUdpPort needs to get passed to goscrape.asyncSession from NewBulk().

@stephen304
Copy link
Owner

Ah, I see what you mean. Here's where I'm really wishing that, for organizational purposes, go had function overloading. I'll return to this in a bit.

@stephen304
Copy link
Owner

I'm a bit occupied with other things at the moment - if you want to make a config struct and implement that I can merge that in

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants