Skip to content

Allow overriding #render_attributes #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephannv merged 1 commit into from
Jan 5, 2026
Merged

Allow overriding #render_attributes #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/blueprint/html.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ module Blueprint::HTML
def element(tag_name : String | Symbol, **attributes, &) : Nil
buffer << "<"
buffer << tag_name
AttributesRenderer.render(attributes, to: buffer)
render_attributes(attributes, to: buffer)
buffer << ">"
BufferRenderer.render(to: buffer) { yield }
buffer << "</"
Expand All @@ -89,7 +89,7 @@ module Blueprint::HTML
def void_element(tag_name : String | Symbol, **attributes) : Nil
buffer << "<"
buffer << tag_name
AttributesRenderer.render(attributes, to: buffer)
render_attributes(attributes, to: buffer)
buffer << ">"
end

Expand Down Expand Up @@ -134,4 +134,8 @@ module Blueprint::HTML
def escape_once(value) : Blueprint::SafeValue
safe EscapeOnce.escape(value)
end

private def render_attributes(attributes : Hash | NamedTuple, to buffer : String::Builder) : Nil
AttributesRenderer.render(attributes, to: buffer)
end
end
8 changes: 4 additions & 4 deletions src/blueprint/html/element_registrar.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ module Blueprint::HTML::ElementRegistrar

def {{method_name.id}}(attributes : NamedTuple | Hash, &block) : Nil
buffer << "<{{tag.id}}"
AttributesRenderer.render(attributes, to: buffer)
render_attributes(attributes, to: buffer)
buffer << ">"
BufferRenderer.render(to: buffer) { yield }
buffer << "</{{tag.id}}>"
end

def {{method_name.id}}(attributes : NamedTuple | Hash) : Nil
buffer << "<{{tag.id}}"
AttributesRenderer.render(attributes, to: buffer)
render_attributes(attributes, to: buffer)
buffer << "></{{tag.id}}>"
end
end
Expand All @@ -34,7 +34,7 @@ module Blueprint::HTML::ElementRegistrar

def {{method_name.id}}(attributes : NamedTuple | Hash) : Nil
buffer << "<{{tag.id}}"
AttributesRenderer.render(attributes, to: buffer)
render_attributes(attributes, to: buffer)
buffer << "></{{tag.id}}>"
end
end
Expand All @@ -48,7 +48,7 @@ module Blueprint::HTML::ElementRegistrar

def {{method_name.id}}(attributes : NamedTuple | Hash) : Nil
buffer << "<{{tag.id}}"
AttributesRenderer.render(attributes, to: buffer)
render_attributes(attributes, to: buffer)
buffer << ">"
end
end
Expand Down