fix: eliminate needless lifetimes#501
Merged
stepchowfun merged 1 commit intostepchowfun:mainfrom Nov 30, 2024
chenrui333:rust-1.83.0
Merged
fix: eliminate needless lifetimes#501stepchowfun merged 1 commit intostepchowfun:mainfrom chenrui333:rust-1.83.0
stepchowfun merged 1 commit intostepchowfun:mainfrom
chenrui333:rust-1.83.0
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
6 tasks
Owner
|
Thank you! I'm not sure why the CI (which has already been updated to use Rust 1.83.0) didn't catch this. |
Owner
|
Oh I think I understand why the CI didn't catch this. The CI did catch it in #499, and I had fixed it in a different way by adding the elided lifetime: fn source<'a>(&'a self) -> Option<&'a (dyn error::Error + 'static)> {But this fix in this PR (not explicitly quantifying over the lifetime in the first place) is better: fn source(&self) -> Option<&(dyn error::Error + 'static)> {So, I think this PR is technically unnecessary; the build should already be passing on the latest commit before this PR. But I think this PR makes the code slightly better! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seeing some regression build issue against rust 1.83.0 as
Status: Ready
relates to Homebrew/homebrew-core#199379