Conversation
* push on master and release branch staging tags * make contract code hash null for history operations
* update deps;2A * Add dependabot * lint
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Release PR that removes unreliable Soroban contract_code_hash extraction (now emitted as nil) and refreshes dependency management.
Changes:
- Set
contract_code_hashtonilfor Soroban-related operation types and remove the footprint-based hash extraction helpers. - Update Go module dependencies (
go.mod/go.sum). - Add Dependabot configuration for weekly updates across Go modules, GitHub Actions, and Docker.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/transform/operation.go | Sets contract_code_hash to nil for Soroban ops and removes hash-extraction helpers. |
| internal/transform/operation_test.go | Updates unit test expectations to nil for contract_code_hash. |
| go.mod | Bumps Go dependencies (direct + indirect). |
| go.sum | Updates dependency checksums to match module upgrades. |
| .github/dependabot.yml | Adds Dependabot config for automated weekly dependency updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - package-ecosystem: "docker" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| day: "sunday" | ||
| time: "02:00" |
There was a problem hiding this comment.
The Docker Dependabot update is configured to scan directory "/", but this repo’s Dockerfiles are under "/docker" (e.g., docker/Dockerfile, docker/Dockerfile.test). As-is, Dependabot is likely to miss Dockerfile base-image updates in that folder. Consider changing the docker entry’s directory to "/docker" or adding an additional docker update entry for "/docker" (and keep "/" only if you also want to update docker-compose.yaml at the repo root).
Summary
contract_code_hashtonilfor all Soroban operation types (invoke contract, create contract, create contract v2, upload wasm, extend footprint TTL, restore footprint) — removes unreliable hash extraction from transaction envelope footprintsTest plan
nilforcontract_code_hashgo test ./internal/transformpasses