Conversation
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates TypeScript typing configuration and dependency constraints to keep the monorepo build stable after dependency upgrades, specifically preventing accidental adoption of incompatible React v19 type packages and limiting TypeScript versions to supported ranges.
Changes:
- Restrict server TypeScript auto-discovered typings by explicitly setting
typestonodeandexpress. - Adjust
@types/react/@types/react-domranges in the client package to stay within React 18 types. - Add root
resolutionsto pin@types/reactand@types/react-domto specific React 18 patch versions.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/demo-wallet-server/tsconfig.json | Adds explicit types to prevent unwanted transitive @types/* auto-inclusion and related build failures. |
| packages/demo-wallet-client/package.json | Changes React type packages to ~18.2.x ranges to avoid pulling v19 types. |
| package.json | Pins @types/react and @types/react-dom via Yarn resolutions to known-good React 18 versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Preview is available here: |
|
Preview is available here: |
Summary
yarn upgradeto update all dependencies to their latest semver-compatible (minor/patch) versions across the monorepo@types/react(18.2.79) and@types/react-dom(18.2.25) via resolutions to prevent transitive v19 types from breaking the buildtypescriptto~5.1.6in all packages to stay within@typescript-eslintv6's supported range (<5.2.0)clean-webpack-pluginwith webpack 5's built-inoutput.clean: true, removing the stray@types/minimatchtransitive dependency@babel/plugin-transform-private-property-in-objectto replace the deprecated@babel/plugin-proposal-private-property-in-objectNotable upgrades
Socket security alerts resolved
@babel/plugin-transform-private-property-in-objectclean-webpack-pluginin favor of webpack 5 built-inoutput.cleanWhat's NOT included (major version bumps for future work)