Conversation
There was a problem hiding this comment.
Pull request overview
Adds additional Soroban/Stellar network config setting fields (P23 settings and P26 CAP-77 frozen ledger keys) to the dbt source/staging schemas and documentation.
Changes:
- Extend
config_settingssource + staging schemas with new P23/P26-related columns. - Update the staging select list to include the new columns from the raw source.
- Document new config-setting IDs and add doc blocks for the new fields.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| models/staging/stg_config_settings.yml | Adds schema.yml column entries for the new P23/P26 config settings in the staging model. |
| models/staging/stg_config_settings.sql | Adds the new columns to the staging model SELECT list from the raw source. |
| models/sources/src_config_settings.yml | Adds the new columns to the raw source schema definition. |
| models/marts/ledger_current_state/config_settings_current.yml | Documents the new columns on the “current” mart model. |
| models/docs/sources/config_settings.md | Adds new config-setting ID mappings and docs blocks for the new fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: ledger_max_dependent_tx_clusters | ||
| description: '{{ doc("ledger_max_dependent_tx_clusters") }}' | ||
|
|
||
| - name: tx_max_footprint_entries | ||
| description: '{{ doc("tx_max_footprint_entries") }}' |
There was a problem hiding this comment.
The schema for config_settings_current documents new columns (e.g., ledger_max_dependent_tx_clusters, tx_max_footprint_entries, SCP timing fields, and CAP-77 frozen-key fields), but models/marts/ledger_current_state/config_settings_current.sql does not select or expose these fields from stg_config_settings. As-is, the model output will be missing these columns (and elementary.schema_changes may warn). Update config_settings_current.sql to include the new fields in both the current_settings CTE and the final select.
| -- P23 config settings | ||
| , ledger_max_dependent_tx_clusters | ||
| , tx_max_footprint_entries | ||
| , ledger_target_close_time_milliseconds | ||
| , nomination_timeout_initial_milliseconds | ||
| , nomination_timeout_increment_milliseconds | ||
| , ballot_timeout_initial_milliseconds | ||
| , ballot_timeout_increment_milliseconds | ||
| -- P26 CAP-77 frozen ledger keys |
There was a problem hiding this comment.
PR metadata still contains the TODO template (What/Why/Known limitations), and the code changes include both P23 settings (parallel compute / ledger cost ext / SCP timing) and P26 CAP-77 settings. Please update the PR description (and/or title) to reflect the actual scope so reviewers and release notes are accurate.
| , frozen_ledger_keys | ||
| , frozen_ledger_keys_delta | ||
| , freeze_bypass_txs | ||
| , freeze_bypass_txs_delta |
There was a problem hiding this comment.
Updates based on comments from stellar/stellar-etl#401
PR Checklist
PR Structure
otherwise).
Thoroughness
Release planning
semver, and I've changed the name of the BRANCH to major/* , minor/* or patch/* .
What
[TODO: Short statement about what is changing.]
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]