Skip to content

Pass through strkey and xdr2json changes#135

Open
chowbao wants to merge 4 commits intomasterfrom
minor/add-strkey-and-xdr-json-columns
Open

Pass through strkey and xdr2json changes#135
chowbao wants to merge 4 commits intomasterfrom
minor/add-strkey-and-xdr-json-columns

Conversation

@chowbao
Copy link
Copy Markdown
Contributor

@chowbao chowbao commented Jun 23, 2025

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to major/* , minor/* or patch/* .

What

Pass through the strkey and xdr2json changes to dbt tables

Why

Use updated info for our dbt tables

Known limitations

  • Need to test

@chowbao chowbao requested a review from a team as a code owner June 23, 2025 22:17
Copy link
Copy Markdown
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sydneynotthecity
Copy link
Copy Markdown
Contributor

@chowbao whenever you merge this PR, do you mind updating the token transfers docs to remove the * from the amount_raw field description? I think it's causing our build pipeline to fail with error

BigQuery error in update operation: The description for field amount is too
long. The maximum length is 1024 characters.
Error: Process completed with exit code 1.

My guess is the special character is somehow messing up the schema update script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants