Remove custom Buffer.subarray polyfill#128
Merged
Shaptic merged 2 commits intostellar:masterfrom Jun 20, 2025
Merged
Conversation
Contributor
Author
|
Hi @Shaptic, we should also merge this PR. |
Shaptic
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the latest version of React Native, the current patch implementation seems to not work smoothly, so let's remove it and instead use
@exodus/patch-broken-hermes-typed-arraysto fix this issue. The@exodus/patch-broken-hermes-typed-arraysis used by well-known applications like Rabby Wallet and Exodus, so I believe it should be trustworthy.P.S. Without removing this patch, using @exodus/patch-broken-hermes-typed-arrays can also make everything work smoothly, so there is no rush to release a new version.