core: add support for extra volumes and secret#160
Open
jacekn wants to merge 2 commits intostellar:mainfrom
Open
core: add support for extra volumes and secret#160jacekn wants to merge 2 commits intostellar:mainfrom
jacekn wants to merge 2 commits intostellar:mainfrom
Conversation
### What This PR will allow operators to mount extra secret and volumes in the core and core-init containers. ### Why To allow us to run multiple validators from one StatefulSet we need a way for each pod to use different seed. Having capability to use pre-existing secret and memory-backed empty dir will allow operators to prepare seeds in the init continainer and consume them in the core container.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Helm chart configurability to mount an operator-provided Secret and arbitrary additional volumes/volumeMounts into the core-init and core containers, enabling per-pod seed handling for multi-validator StatefulSets.
Changes:
- Introduces
core.existingSecretto mount a pre-existing Kubernetes Secret intocore-initandcore. - Adds
core.extraVolumesandcore.extraVolumeMountsto extend the pod spec and mount extra volumes intocore-initandcoreonly. - Bumps the
corechart version to0.8.0.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/core/values.yaml | Documents new existingSecret, extraVolumes, and extraVolumeMounts values. |
| charts/core/templates/core-sts.yaml | Wires new values into StatefulSet volume/volumeMount generation for init/core containers. |
| charts/core/Chart.yaml | Updates chart version for the new feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR will allow operators to mount extra secret and volumes in the core and core-init containers.
Why
To allow us to run multiple validators from one StatefulSet we need a way for each pod to use different seed.
Having capability to use pre-existing secret and memory-backed empty dir will allow operators to prepare seeds in the init continainer and consume them in the core container.