core: improve port and runStandalone support#158
Merged
jacekn merged 1 commit intostellar:mainfrom Apr 9, 2026
Merged
Conversation
Contributor
jacekn
commented
Apr 9, 2026
jacekn
commented
- fix quotes for the runStandalone option
- ensure peer port is exposed
- ensure port numbers come from config
- as drive-by bump appVersion to match latest core release
* fix quotes for the runStandalone option * ensure peer port is exposed * ensure port numbers come from config * as drive-by bump appVersion to match latest core release
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Stellar Core Helm chart to correctly wire configurable ports into the StatefulSet/Service, expose the peer port, and align the chart’s app version with the latest core release.
Changes:
- Use
core.config.httpPort/core.config.peerPort(with defaults) for container and Service ports, and expose the peer port. - Render
RUN_STANDALONEwithout quoting to match expected config syntax. - Bump chart
versionandappVersion.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/core/templates/core-sts.yaml | Parameterizes HTTP/peer ports and exposes peer port via container + Service ports. |
| charts/core/templates/core-cm.yaml | Fixes RUN_STANDALONE rendering by removing quotes. |
| charts/core/Chart.yaml | Updates chart version and appVersion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
satyamz
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.