Improve history archive handling in the core chart#155
Merged
jacekn merged 1 commit intostellar:mainfrom Mar 6, 2026
Merged
Conversation
This PR improves how we handle history archives * switch service to headless and enable publishing of NotReadyNodes. This is needed because history archive should be served even if the node is catching up * expose port 80 (history archive) if archive is enabled * add ingressClassName to the history Ingress * add new "router" Deployment and Service. This is needed for exposing individual archives. * as a drive-by fix I also removed duplicated port definition in the init container as it was causing errors
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the core Helm chart’s history archive exposure so archives remain reachable while nodes are catching up, and adds a routing layer to expose per-pod archives.
Changes:
- Converts the core Service to a headless Service with
publishNotReadyAddresses: trueand conditionally exposes port 80 whenhistoryProxyis enabled. - Adds a new “history router” nginx Deployment/Service (and ConfigMap) plus optional
ingressClassNamesupport on the history Ingress. - Bumps the chart version and adjusts
values.yamlto include router replica count and ingressClassName example.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| charts/core/values.yaml | Adds historyProxy.replicaCount and documents ingressClassName for the history ingress. |
| charts/core/templates/history-proxy.yaml | Introduces the history-router nginx ConfigMap + Deployment, updates Service selectors, and adds ingressClassName support. |
| charts/core/templates/core-sts.yaml | Makes the core Service headless with publishNotReadyAddresses, and conditionally exposes port 80 for history archive serving. |
| charts/core/Chart.yaml | Bumps chart version to reflect the chart behavior change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
travertischio
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves how we handle history archives