Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the friendbot Helm chart to improve configuration management and flexibility while aiming to remain backwards compatible.
Changes:
- Add support for using an existing Kubernetes Secret and move non-sensitive settings into a ConfigMap.
- Add new configuration options (otel, rpc_url, fund_contract_addresses) and allow setting
ingressClassName. - Add Deployment-level annotations and allow non-standard deployment strategies.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/friendbot/values.yaml | Documents new values for secret/configmap, ingressClassName, deployment strategy/annotations |
| charts/friendbot/templates/friendbot-secret.yaml | Creates a Secret only when existingSecret is not provided; now only stores seed material |
| charts/friendbot/templates/friendbot-config.yaml | New ConfigMap rendering friendbot.conf with non-sensitive settings + new options |
| charts/friendbot/templates/friendbot-deployment.yaml | Mounts Secret + ConfigMap, adds container port, adds deployment annotations + configurable strategy |
| charts/friendbot/templates/friendbot-ingress.yaml | Adds optional spec.ingressClassName |
| charts/friendbot/templates/_helpers.tpl | Adds helper for selecting Secret name (generated vs existing) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jacekn
force-pushed
the
refresh
branch
2 times, most recently
from
6869451 to
9ea7d85
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The changes should be backwards compatible * add support for pre-existing secret * move non-sensitive config from a Secret to a ConfigMap * add support for otel config options * add support for using rpc_url * add support for using fund_contract_addresses * add support for adding Deployment annotations * add support for non-standard deployment strategy * add support for setting ingressClassName
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The changes should be backwards compatible but there is some internal rewiring to port numbers