Skip to content

SDP-1596 add new broker type scheduler and deprecate enable schedule config #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpohr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SDP-1596 add new broker type scheduler and deprecate enable schedule config #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions charts/stellar-disbursement-platform/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
apiVersion: v2
name: stellar-disbursement-platform
description: A Helm chart for the Stellar Disbursement Platform Backend (A.K.A. `sdp`)
version: "3.6.3"
appVersion: "3.6.1"
version: "3.7.0"
appVersion: "3.7.0"
type: application
maintainers:
- name: Stellar Development Foundation
sources:
- https://github.com/stellar/stellar-disbursement-platform-backend
- https://github.com/stellar/stellar-disbursement-platform-frontend
- https://github.com/stellar/helm-charts

3 changes: 1 addition & 2 deletions charts/stellar-disbursement-platform/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ These parameters are shared by all charts.
| `global.deployment.topologySpreadConstraints` | Pod topology spread constraints for all services. | `[]` |
| `global.ephemeralDatabase` | Enables or disables the creation of an ephemeral database for testing purposes. | `true` |
| `global.eventBroker` | Configuration related to the event broker used by the application. | |
| `global.eventBroker.type` | The type of event broker to be used. Options: "NONE", "KAFKA". Default: "KAFKA". | `KAFKA` |
| `global.eventBroker.type` | The type of event broker to be used. Options: "SCHEDULER", "KAFKA". Default: "SCHEDULER". | `SCHEDULER` |
| `global.eventBroker.urls` | A comma-separated list of broker URLs for the event broker. | `nil` |
| `global.eventBroker.consumerGroupId` | The consumer group ID for the event broker. | `nil` |
| `global.eventBroker.kafka` | Configuration related to the Kafka event broker. | |
Expand Down Expand Up @@ -141,7 +141,6 @@ Configuration parameters for the SDP Core Service which is the core backend serv
| `sdp.configMap.data.DISABLE_MFA` | Determines if email-based MFA should be disabled during login ("true" or "false"). | `false` |
| `sdp.configMap.data.SDP_UI_BASE_URL` | The base URL of the SDP UI/dashboard. | `nil` |
| `sdp.configMap.data.INSTANCE_NAME` | The name of the SDP instance. Example: "SDP Testnet". | `nil` |
| `sdp.configMap.data.ENABLE_SCHEDULER` | Whether the scheduled jobs are enabled in this instance ("true" or "false"). Default "false". | `false` |
| `sdp.configMap.data.SCHEDULER_PAYMENT_JOB_SECONDS` | The interval in seconds for the payment job that syncs payments between the SDP and the TSS. | `10` |
| `sdp.configMap.data.SCHEDULER_RECEIVER_INVITATION_JOB_SECONDS` | The interval in seconds for the receiver invitation job that sends invitations to new receivers. 0 or negative values disable the job. | `10` |
| `sdp.configMap.data.MAX_INVITATION_RESEND_ATTEMPTS` | The maximum number of times an invitation can be resent. 0 or negative values disable the job. | `3` |
Expand Down
6 changes: 2 additions & 4 deletions charts/stellar-disbursement-platform/minimal-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@

global:
## @extra global.eventBroker Configuration related to the event broker used by the application.
## @param global.eventBroker.type The type of event broker to be used. Options: "NONE", "KAFKA". Default: "KAFKA".
## @param global.eventBroker.type The type of event broker to be used. Options: "KAFKA", "SCHEDULER". Default: "SCHEDULER".
## @param global.eventBroker.urls A comma-separated list of broker URLs for the event broker.
## @param global.eventBroker.consumerGroupId The consumer group ID for the event broker.
eventBroker:
type: "NONE"
type: "SCHEDULER"

sdp:

Expand All @@ -20,15 +20,13 @@ sdp:
domain: #required
mtnDomain: #required

## @param sdp.configMap.data.ENABLE_SCHEDULER Whether the scheduled jobs are enabled in this instance ("true" or "false"). Setting to "true" because broker type is `NONE`.
## @param sdp.configMap.data.SEP10_SIGNING_PUBLIC_KEY Anchor platform SEP10 signing public key.
## @param sdp.configMap.data.DISTRIBUTION_PUBLIC_KEY The public key of the Stellar distribution account that sends the Stellar payments.
## @param sdp.configMap.data.RECAPTCHA_SITE_KEY Site key for ReCaptcha. Required if using ReCaptcha.
## @param sdp.configMap.data.INSTANCE_NAME The name of the SDP instance. Example: "SDP Testnet".
configMap:
annotations:
data:
ENABLE_SCHEDULER: "true"
SEP10_SIGNING_PUBLIC_KEY: #required
DISTRIBUTION_PUBLIC_KEY: #required
RECAPTCHA_SITE_KEY: #required
Expand Down
6 changes: 2 additions & 4 deletions charts/stellar-disbursement-platform/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,11 @@ global:
ephemeralDatabase: true

## @extra global.eventBroker Configuration related to the event broker used by the application.
## @param global.eventBroker.type The type of event broker to be used. Options: "NONE", "KAFKA". Default: "KAFKA".
## @param global.eventBroker.type The type of event broker to be used. Options: "KAFKA", "SCHEDULER". Default: "SCHEDULER".
## @param global.eventBroker.urls A comma-separated list of broker URLs for the event broker.
## @param global.eventBroker.consumerGroupId The consumer group ID for the event broker.
eventBroker:
type: "KAFKA"
type: "SCHEDULER"
urls: #required
consumerGroupId: #required

Expand Down Expand Up @@ -166,7 +166,6 @@ sdp:
## @param sdp.configMap.data.DISABLE_MFA Determines if email-based MFA should be disabled during login ("true" or "false").
## @param sdp.configMap.data.SDP_UI_BASE_URL The base URL of the SDP UI/dashboard.
## @param sdp.configMap.data.INSTANCE_NAME The name of the SDP instance. Example: "SDP Testnet".
## @param sdp.configMap.data.ENABLE_SCHEDULER Whether the scheduled jobs are enabled in this instance ("true" or "false"). Default "false".
## @param sdp.configMap.data.SCHEDULER_PAYMENT_JOB_SECONDS The interval in seconds for the payment job that syncs payments between the SDP and the TSS.
## @param sdp.configMap.data.SCHEDULER_RECEIVER_INVITATION_JOB_SECONDS The interval in seconds for the receiver invitation job that sends invitations to new receivers. 0 or negative values disable the job.
## @param sdp.configMap.data.MAX_INVITATION_RESEND_ATTEMPTS The maximum number of times an invitation can be resent. 0 or negative values disable the job.
Expand All @@ -189,7 +188,6 @@ sdp:
DISABLE_RECAPTCHA: "false"
DISABLE_MFA: "false"
INSTANCE_NAME: #required
ENABLE_SCHEDULER: "false"
SCHEDULER_PAYMENT_JOB_SECONDS: "10"
SCHEDULER_RECEIVER_INVITATION_JOB_SECONDS: "10"
MAX_INVITATION_RESEND_ATTEMPTS: "3"
Expand Down