doc: fix txnbuild basic example timebounds usage#5917
Open
kevinsheth wants to merge 4 commits intostellar:mainfrom
Open
doc: fix txnbuild basic example timebounds usage#5917kevinsheth wants to merge 4 commits intostellar:mainfrom
kevinsheth wants to merge 4 commits intostellar:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the txnbuild “Create an account” basic example to use the current txnbuild API for setting time bounds via TransactionParams.Preconditions.TimeBounds instead of the deprecated/older TransactionParams.Timebounds field.
Changes:
- Replace
TransactionParams.Timeboundsusage withTransactionParams.Preconditions.TimeBoundsin the Go example.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates
docs/reference/examples.mdto set time bounds viaTransactionParams.Preconditions.TimeBoundsin the basic txnbuild example.Why
The previous snippet used
Timeboundsdirectly inTransactionParams, which is outdated.Current txnbuild usage sets time bounds under
Preconditions, so this change prevents confusionfor developers following the example.
Known limitations
N/A (docs-only change).