This repository was archived by the owner on Sep 12, 2019. It is now read-only.
fix documentation: api_key -> apiKey #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suggested by one of our partners
Contributor
|
Yes, this is correct. The name of the field is different in docs and different in code. I think we should stick to |
Author
|
Ok, but then that may be a breaking change for consumers who have already implemented it the old way. Can I file this issue to you for the code change since you are already working on bridge? |
Contributor
|
I think we can explain that this is a breaking change in release notes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggested by one of our partners -- let me know if this change makes sense, I've not tested it out myself to know if this is correct @bartekn