Improves the approach to providing the metadata to the user. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puts the data relative to where the user is running their program. Removes the metadata from the repository and uses the IPAC hosted version instead.
golmschenk
commented
Apr 27, 2025
| self.alert_id2 = self.metadata['alert_id2'].values[0] | ||
| self.alert_x2 = self.metadata['alert_x2'].values[0] | ||
| self.alert_y2 = self.metadata['alert_y2'].values[0] | ||
| self.ROW_IDX = self.metadata['ROW_IDX'].values[0] |
Contributor
Author
There was a problem hiding this comment.
These seemed to be metadata rows that don't exist in the IPAC version and just seemed to increment with the light curves. I'm guessing these were an artifact that was adding during the original metadata file creation? I don't believe they are needed.
golmschenk
commented
Apr 27, 2025
| "tqdm>=4.66.3", | ||
| "pytest>=7.1.3", | ||
| "pytest-pycharm>=0.7.0", | ||
| "astropy>=6.0.0", |
Contributor
Author
There was a problem hiding this comment.
Added astropy because it includes a reader for the ipac data format. This makes it easy to convert that format to Pandas, and from there to .feather.
golmschenk
commented
Apr 27, 2025
| # Project specific | ||
|
|
||
| /.idea/ | ||
| /data/metadata.ipac |
Contributor
Author
There was a problem hiding this comment.
No need to track these data files in git.
Update the readme to no longer use the removed ROW_NUM.
golmschenk
force-pushed
the
metadata_automatic_download
branch
from
a745661 to
442f397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9. Makes metadata download happen upon first use. Puts the data relative to where the user is running their program. Removes the metadata from the repository and uses the IPAC hosted version instead.