-
Notifications
You must be signed in to change notification settings - Fork 57
feat: add tags (hashtag) support #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PeterRosdahl
wants to merge
1
commit into
steipete:main
Choose a base branch
from
PeterRosdahl:feature/tags-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+298
−9
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import Commander | ||
| import Foundation | ||
| import RemindCore | ||
|
|
||
| enum TagsCommand { | ||
| static var spec: CommandSpec { | ||
| CommandSpec( | ||
| name: "tags", | ||
| abstract: "List tags or reminders for a tag", | ||
| discussion: "Without an argument, prints all tags with counts. With a tag, shows reminders that match it.", | ||
| signature: CommandSignatures.withRuntimeFlags( | ||
| CommandSignature( | ||
| arguments: [ | ||
| .make(label: "tag", help: "Tag name", isOptional: true) | ||
| ] | ||
| ) | ||
| ), | ||
| usageExamples: [ | ||
| "remindctl tags", | ||
| "remindctl tags shopping", | ||
| ] | ||
| ) { values, runtime in | ||
| let requestedTag = values.argument(0) | ||
|
|
||
| let store = RemindersStore() | ||
| try await store.requestAccess() | ||
| let reminders = try await store.reminders(in: nil) | ||
|
|
||
| if let requestedTag { | ||
| let parsed = try CommandHelpers.parseTags([requestedTag]) | ||
| guard let filterTag = parsed.first, parsed.count == 1 else { | ||
| throw RemindCoreError.operationFailed("Provide a single tag") | ||
| } | ||
| let key = filterTag.lowercased() | ||
| let matching = reminders.filter { reminder in | ||
| reminder.tags.contains { $0.lowercased() == key } | ||
| } | ||
| OutputRenderer.printReminders(matching, format: runtime.outputFormat) | ||
| return | ||
| } | ||
|
|
||
| var byKey: [String: TagSummary] = [:] | ||
| for reminder in reminders { | ||
| for tag in reminder.tags { | ||
| let key = tag.lowercased() | ||
| let existing = byKey[key] | ||
| byKey[key] = TagSummary(tag: existing?.tag ?? tag, count: (existing?.count ?? 0) + 1) | ||
| } | ||
| } | ||
|
|
||
| OutputRenderer.printTagSummaries(Array(byKey.values), format: runtime.outputFormat) | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When tag flags are used together with
--title, this path parses tags from the new title (title ?? reminder.title) instead of the current reminder, so existing tags are silently dropped before--tag/--remove-tagis applied. For example, editing a reminder that already has#workwithedit 1 --title "New" --tag urgentends up with only#urgent, which causes unintended tag loss whenever users combine title updates with tag updates.Useful? React with 👍 / 👎.