fix: apply history filters before limit #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply --start/--end/--participants in SQL so LIMIT applies after filtering (CLI history + RPC messages.history). Add regressions proving filtered windows work with small limits.
steipete
force-pushed
the
fix/history-filters-before-limit
branch
from
3285fbc to
0fb6e59
Compare
Owner
|
Landed via temp rebase onto main.\n\n- Gate: pnpm lint && pnpm build && pnpm test (fails: no package.json); make lint && make build && make test\n- Land commit: 0fb6e59\n- Merge commit: 40e2084\n\nThanks @tommybananas! |
micahbrich
pushed a commit
to micahbrich/imsg-plus
that referenced
this pull request
Jan 30, 2026
micahbrich
pushed a commit
to micahbrich/imsg-plus
that referenced
this pull request
Jan 30, 2026
…before-limit fix: apply history filters before limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix
imsg history(and RPCmessages.history) so--start/--end/--participantsare applied in SQL beforeLIMIT.Why
Previously the tool would fetch the newest N messages, then filter in-memory, so older time windows could return no results unless
--limitwas inflated.How to verify
make testimsg history --chat-id <id> --start <older-window> --end <older-window-end> --limit 50now returns results even when the window is outside the newest 50 messages.