Skip to content

fix(cli): generate native zsh completions #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
piiq wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −4
Draft

fix(cli): generate native zsh completions #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions internal/cmd/completion_scripts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,24 @@ complete -F _gog_complete gog
func zshCompletionScript() string {
return `#compdef gog

autoload -Uz bashcompinit
bashcompinit
` + bashCompletionScript()
_gog() {
local -a args completions

args=("${(@)words[1,CURRENT]}")
if (( CURRENT > ${#words} )); then
args+=("")
fi

completions=("${(@f)$(gog __complete --cword "$((${#args[@]} - 1))" -- "${args[@]}" 2>/dev/null)}")
if (( ${#completions[@]} == 0 )); then
return 1
fi

compadd -Q -S '' -- "${completions[@]}"
}

compdef _gog gog
`
}

func fishCompletionScript() string {
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/completion_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
func TestCompletionCmd(t *testing.T) {
cases := map[string]string{
"bash": "complete -F _gog_complete gog",
"zsh": "bashcompinit",
"zsh": "compdef _gog gog",
"fish": "complete -c gog",
"powershell": "Register-ArgumentCompleter",
}
Expand Down