Merged
Conversation
sunkan
requested changes
Jan 26, 2026
This should fix an issue with nested allOf which would fail when trying to merge since the path was not absolute. So we keep track of the internal parents path through the recursion to ensure the absolute path within the document is kept track of. Also ensure that if models are part of multiple allOf, that they will be merged correctly.
The idea is to fix an issue with a model being references in several allOf clauses. So we keep track of each model and the allOf's in that model. When we encounter the same model again, we add all of the model's allOf paths to the allOf collector array for later reference when merging the schema.
This test verifies that multiple uses of models in allOf work as expected when using the AllOfMerger. Also ensures that abosulte paths are used when resolving the allOfs in the merger.
sunkan
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few issues relating to inlining
allOfclauses:allOfbut path reference is not absoluteallOfclauses