Fix external complex dependencies being overwritten when inlining#1
Merged
sunkan merged 2 commits intostefna:mainfrom Oct 30, 2025
Merged
Conversation
If an external complex reference has more than one path, the inlined schema will effectively have all the external paths reference the same model. Adding the uri part ensures that the external models are not overwritten.
Member
|
@runar-stefna LGTM. But can you add a test to show this? |
Verify that when multiple paths are defined from the same external package, the inliner does not overwrite all the path definitions with the same model.
sunkan
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an external complex reference has more than one path, the inlined schema will effectively have all the external paths reference the same model. Adding the uri part ensures that the external models are not overwritten.