A much shorter script #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Arnoques wants to merge 2 commits into steffenr:master from Arnoques:master

Arnoques commented Jul 16, 2013

If anyone is interested, I refactored the code to avoid the many duplications I found. I tested:

both orientations
clicking on a date or on button
clicking very fast to try to go past the limits

I didn't test:

keyboard navigation
autoplay (it didn't work for me in the original file)

I don't have much experience with JS or jQuery, so any comment is appreciated.

Arnoques added 2 commits

July 16, 2013 02:00


          Refactored the code to avoid duplication.

ccaafb4


          Reverted unintended change to the defaults.

39e0e6e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet